2074: add target="_blank" for each link

ha**@rekk***** (Google Code) (Is this you? Claim this profile.)
Jan. 21, 2012 
One suggestion if you can fix on reviewboard - see if you can please add target="_blank" for every link such as "Testing" section. I find it annoying that it does not take me to new window, instead just same window and I closed it and now I have to find reviewboard link to go back to where I was.

<a href="link-here" target="_blank">link name</a>
david
#1 david
  • +EasyFix
#2 jimr*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Just to clarify this issue before I started working on it:
The problem here is that in "Description" and "Testing Done", any string that is matched as URLs are "linkified" by the function linkifyText in reviews.js. By "linkifying" the URLs, an anchor tag is created, but without target="_blank" attribute. So the fix is simply modifying the review.js file to include this attribute in the anchor tag
#3 jimr*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Review request submitted http://reviews.reviewboard.org/r/2804/, pending for code review
david
#4 david 
Fixed in master (a4c38cd).
  • +Fixed