2046: post-review always use a proxy even for local network

sebastie********@gmai***** (Google Code) (Is this you? Claim this profile.)
March 26, 2011
What version are you running?
RBTools 0.3.2

What's the URL of the page containing the problem?
NA

What steps will reproduce the problem?
1. In Windows XP, configure proxy using environment variable http_proxy
2. Use post-review with subversion local repository to create a review in localhost reviewboard.
3. post-review uses proxy whereas reviewboard is on localhost.

What is the expected output? What do you see instead?
It should be possible to deactivate proxy using a command line switch --no-proxy for example.

What operating system are you using? What browser?
Windows XP, FF4.

Please provide any additional information below.
I hacked postreview.py by saying urllib2 top not use proxy and this fixed the problem.
david
#1 david
You need to also set the no_proxy environment variables for hosts which shouldn't use a proxy (such as "localhost").
  • +UserError
#2 sebastie********@gmai***** (Google Code) (Is this you? Claim this profile.)
ok. I didn't see documentation on that. Thanks.