2043: Using reviewboard without a repository - only upload a diff file
- Fixed
- Review Board
| nicolas.*********@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Feb. 4, 2014 | |
| 2799 |
What version are you running? 1.5.2 What's the URL of the page this enhancement relates to, if any? Describe the enhancement and the motivation for it. We currently use mercurial and SVN (legacy) as our reposirories. Most of the time, this works 100%. There are some cases with mercurial when we would like to review a patch (diff) but the parents are not on the server. In theory, using the parent diff could solve the problem, but it happened a few times when the changes and merges made it too complicated for some of the end users to generate the parent patch. Therefore, in those case, even if we lose a few features (like the code expansion over the 3 lines given in the diff), we would like to be able to create a review with only the patch file, and no link to the repository behind. What operating system are you using? What browser? Windows, Chrome (and others, depending on our users). Please provide any additional information below. We are open to alternative solutions, among others, if we could serve our local repo for a few moments, while the review is being created, this would help go around the problem. Thanks!
I guess this feature will be great when using SCM not supported by Review Board.
vote +1. Considering we only need to review the diff and don't care which repository it belongs to.
We have SVN repository hosted at client side which needs VPN connection. This means that the server where Review Board is deployed, must be running VPN client to connect to VPN. This is not a feasible option. Besides, code review is to be done before any check ins so basically I am taking diff from my working copy which is not yet checked in. Since there are simultaneous check ins by other developers, the diff I had taken, may not be in sync with the trunk because of intermediate check ins by other members. I have been using CodeStriker which takes care of all these issues by ... 1. Upload a diff/patch file without specifying the repository 2. I can view the only changed portion of files side by side in Codestriker (Note without repository specified) 3. CodeStriker allows me to upload my modified file for whole file viewing Side by side, called parallel viewing. This is indeed a wonderful feature. Can we expect the same in ReviewBoard for diff uploads without repository.
Showing diffs without a backing repository is not a high priority for us. > In theory, using the parent diff could solve the problem, but it happened > a few times when the changes and merges made it too complicated for some > of the end users to generate the parent patch. Improving DVCS support in post-review is really the best way to solve this. > Since there are simultaneous check ins by other developers, the diff I had > taken, may not be in sync with the trunk because of intermediate check ins > by other members. The diffs posted to reviewboard include revision information, so the fact that other people have committed code doesn't matter.
-
+ Component-DiffViewer
This is sort of done via the ability to review attached text files. I think that's probably as much as we'll put into this.
-
+ Fixed
Reviewing attached text files is insufficient because you do not get the ability to comment on specific lines of the text file. I think this would be a great feature for content that does not belong to any scm system at all. The content would not be evolving over time, yet you want an initial review prior to "going live". The use case I have right now is a blog post. I'd like to develop the post, and then perhaps send it around to a few people for review, and then once we are good post it. It doesn't really make sense to me to put this into source control because once we post it we have the record and it is for the most part unchanging over time.
As of 2.0.x, you do have the ability to comment on specific lines of the text file.