204: post-review displays incorrect error

eric****@gmai***** (Google Code) (Is this you? Claim this profile.)
Sept. 15, 2007 
post-review will display this error when posting:

Your review request still exists, but the diff is not attached.

I'm not sure what the intent is with that line of code.  My guess is that
it should be indented one level to be part of the except APIError exception
handler.  However, one could argue that even if the diff failed to upload,
it should be allowed to fall through so that you can see the URL (in other
words, just delete that call to die).

This is against r667 of post-review.
david
#1 david 
This was apparently fixed a while ago.
  • +Fixed
  • +Component-Scripts