1986: CVS repository(pserver) addition fails
- Fixed
- Review Board
| tus****@gmai***** (Google Code) (Is this you? Claim this profile.) | |
 |
|
| Feb. 3, 2014 |
What version are you running? 1.5.3 What's the URL of the page containing the problem? http://<hostname>/ReviewBoard/admin/db/scmtools/repository/add/ What steps will reproduce the problem? 1. Try to add a CVS repository 2. 3. What is the expected output? What do you see instead? Successful addition of repository. I see the error "A repository was not found at the specified path." What operating system are you using? What browser? RHEL6, Firefox 3.6.13 Please provide any additional information below.
Same issue with 1.5.4 as well. Can you please look into it ?
-
+ Confirmed -
- Priority-Medium + Priority-Critical + Milestone-Release1.5.x + Component-SCMTools -
+ chipx86
I've been unable to reproduce this. Can you give me an example of the path? Is this by any chance a public repository that I can test with?
-
- Confirmed + NeedInfo
No, it is not a public repository. Example i tried are : <hostnanme>:/abc , with username and password populated :pserver:<username>:<password>@<hostname>:/abc
I am having the same issue. I am using ReviewBoard 1.5.4 installed on Linux Redhat 5.5 (with CentOS release 5.5). I was able to create a Subversion Repository which works fine. But I get the "A repository was not found at the specified path." error message when I try to create a CVS RevfiewBoard Repository, using :pserver:mccorb1@smarts-cvs.lss.emc.com:2906/apps/cvs/smarts and entering my username and password. I also tried other combinations, like :pserver:smarts-cvs.lss.emc.com:2906/apps/cvs/smarts and entering my username and password. Otherwise, I am able to use cvs on the machine where I have ReviewBoard installed, to do checkouts, diffs, etc. Might I be missing something (should I add the CVSROOT variable to the apache environment, e.g., (if yes, how...)??? Any help will be most appreciated -- unfortunately, mine also is a private repository, but if there are any tests I could try, let me know.
When I created the ReviewBoard repository specifying both the username and passsword in the :pserver: string, the repository got created successfully. :pserver:mccorb1:<password>@smarts-cvs.lss.emc.com:2906/apps/cvs/smarts However, when I created a diff file, I got an error message when I tried to create a new Review request: "cvs server: cannot find module `/apps/cvs/smarts/smarts/app-version/Makedefs.pl' - ignored". I was able to create the Review request by editting the diff file and removing the path information that is part of the :pserver: string (the drb file works; drbM is the original): 05:28 /home/mccorb1/SAM82D9B/smarts/app-version 515> diff drb drbM 3c3 < RCS file: smarts/app-version/Makedefs.pl,v --- > RCS file: /apps/cvs/smarts/smarts/app-version/Makedefs.pl,v 18c18 < RCS file: smarts/app-version/misc/Makedefs.pl,v --- > RCS file: /apps/cvs/smarts/smarts/app-version/misc/Makedefs.pl,v 05:28 /home/mccorb1/SAM82D9B/smarts/app-version 516>
-
+
-
+ Milestone-Release1.6.x
-
- NeedInfo + New
Tested with pserver path to remote CVS server and having filled in the Username and Password fields. Checking network traffic with the CVS server shows (obviously obfuscated): BEGIN AUTH REQUEST\x0a/cvsroot/<repo>\x0a<Username>\x0aA\x0aEND AUTH REQUEST\x0a Even though the <Username> is correctly filled in, the <Password> is completely missing. The start of a scrambled password is recognizable (the "A" in between the \x0a characters), but for the rest the password is empty. I would assume the input "id_password" is detected as being filled (hence the attempt to start a scrambled password), but its actual contents is not used.
-
- Milestone-Release1.6.x
-
- New + PendingReview -
- chipx86 + david
I've just submitted a change to master (756bae6) which should fix the most common problems adding CVS repos. If there are other issues, they can be addressed in other bug reports.
-
- PendingReview + Fixed
i am still facing the same issue in Review Board 1.7.21 on Ubuntu 13.04 while adding a private CVS repository. Does anyone knows how to solve the problem. I have tried the following option to add a CVS repo. cvs.example.com/cvsroot :pserver:anonymous@cvs.example.com/cvsroot :pserver:myuser:mypass@cvs.example.com:1234/cvsroot Any help will be most appreciated.
The change for this fix is not in the 1.7.21 release. It will ship in 2.0 beta 3, which is shipping soon (but that's definitely beta-quality). I'll cherry-pick it over to the 1.7.x branch to ship in the next point release.
Do you have a data for the fix in 1.7.x branch? I want to use ReviewBoard to do code review in CVS environment, but it doesn't work in 1.7.21 branch yet. Do you have a workaround instead? or could you please tell me hwo to fix the bug by myself?
If you'd like, you could make the equivalent changes in the code on your system: https://github.com/reviewboard/reviewboard/commit/44e9c25db8ea7dd71ad3fd10927f17c3a86df4b6
I modified and added function check_repository according to the above url. but indicated that "six" variable was not found. and then I added "from django.utils import six" behind the sentense "import urlparse" after comparing with ReviewBoard-2.0beta3's cvs.py. the issue still exists. I have deleted cvs.pyc and cvs.pyo. How can I modify the issue based on 1.7.21 branch? Thanks
Sorry, there's a bug in that change. Replace "six.text_type" with "unicode"
I use ReviewBoard on RHEL6.2 which cvs is 1.11.23 without cvs rls command, so I upgrade cvs to 1.12.12. after upgrade, I can run "cvs -f -d :pserver:tom@10.2.2.34:/data/cvs rls" from shell. but "A repository was not found at the specified path" error still appears. after debug, the actual error is "cvs [rls aborted]: connect to 10.2.2.34(10.2.2.34):2401 failed: Permission denied". it is very strange. In the working environment, I run as root account and the httpd is running as apache account. what happened?
I found the root cause that is selinux is not disabled. after disabling the selinux by setenforce 0 and modify SELINUX from enforcing to disabled under /etc/sysconfig/selinux folder, Review Board works well. Thanks