197: Unable to leave comment if review consists of just 1 binary file

regis.d*******@gmai***** (Google Code) (Is this you? Claim this profile.)
david
 david
Oct. 8, 2007 
What's the URL of the page containing the problem?
http://reviewboard.eng.vmware.com/r/2000/diff/#index_header
(I apologize to non-VMware people for this VMware-internal URL)

What steps will reproduce the problem?
1. Somebody sends a review request with only 1 binary file
2. You try to review that

What is the expected output? What do you see instead?
There is a line that says "This is a binary file. The content cannot be
displayed." where source code usually is. There is no line number on that
line. As such, I cannot drag and drop that line and leave a comment.

What operating system are you using? What browser?
Irrelevant

Please provide any additional information below.
david
#1 david
  • -Priority-Medium
    +Priority-High
    +Component-DiffViewer
    +Usability
david
#2 david
  • +david
david
#3 david
  • +Started
david
#4 david 
I've just committed a change (see http://reviews.review-board.org/r/164/ for details)
that adds a "Review" link to the header of the diff view, which should fix this
problem.  It'll find its way onto reviewboard.eng when we do the next update (should
be soonish)
  • -Started
    +Fixed