1963: HTTP 500 when posting/updating review request via post-review

eal***@gmai***** (Google Code) (Is this you? Claim this profile.)
March 14, 2011 
Running RB 1.5.2 and RBTools 0.3. ReviewBoard is installed on a Linux machine, and post-review is being run from an OS X 10.5 machine.

I'm trying to update an existing review request with an ID of 112. The first time I run the command, it failes with the output below. Then I just re-run the exact same command and it runs without error. This is the scenario I go through about 80% of times when posting something with post-review (we only use post-review to post requests, never manual uploads).

$ post-review -r 112 --revision-range=404fd2a832feee0a35dae9b98471b86ae20e891a:ce39b9a9c0e2e5029d745e7d84a4c0c42981d25a -o
Traceback (most recent call last):
  File "/Users/erik/.virtualenvs/kultinf/bin/post-review", line 9, in <module>
    load_entry_point('RBTools==0.3', 'console_scripts', 'post-review')()
  File "/Users/erik/.virtualenvs/kultinf/lib/python2.5/site-packages/rbtools/postreview.py", line 3766, in main
    submit_as=options.submit_as)
  File "/Users/erik/.virtualenvs/kultinf/lib/python2.5/site-packages/rbtools/postreview.py", line 3437, in tempt_fate
    if not server.info.supports_changesets or not options.change_only:
  File "/Users/erik/.virtualenvs/kultinf/lib/python2.5/site-packages/rbtools/postreview.py", line 793, in _get_server_info
    self._server_info = self._info.find_server_repository_info(self)
  File "/Users/erik/.virtualenvs/kultinf/lib/python2.5/site-packages/rbtools/postreview.py", line 209, in find_server_repository_info
    info = self._get_repository_info(server, repository)
  File "/Users/erik/.virtualenvs/kultinf/lib/python2.5/site-packages/rbtools/postreview.py", line 233, in _get_repository_info
    raise e
rbtools.postreview.APIError: HTTP 500

$ post-review -r 112 --revision-range=404fd2a832feee0a35dae9b98471b86ae20e891a:ce39b9a9c0e2e5029d745e7d84a4c0c42981d25a -o
Review request #112 posted.

https://my-rb-domain.ee:10000/r/112/
chipx86
#1 chipx86 
Was this something that ever happened with RBTools 0.2?

It would be very helpful to see the Review Board log entry for this (assuming logging is turned on).
  • +NeedInfo
#2 eal***@gmai***** (Google Code) (Is this you? Claim this profile.) 
Yes, it happened all the time with 0.2. I was hoping it would go away with 0.3, but no such luck.
I can turn on logging if it's off and send you the log. It's easy to reproduce as it happens virtually every time I use post-review.
chipx86
#3 chipx86 
It's on the Review Board side. Generally, that indicates a sporadic communication problem between Review Board and the SVN repository.
#4 eal***@gmai***** (Google Code) (Is this you? Claim this profile.) 
* Any recommendations on how to deal with the issue?
* Shouldn't post-review handle the error gracefully?

It also throws an ugly error message giving no hints about the real cause of the problem when posting diffs whose parent is not in the SVN repository yet.
chipx86
#5 chipx86 
We should handle it gracefully.

As for debugging the server connection, it appears to be entirely an issue on your end, so there's not much I can do to debug it. It's absolutely not standard behavior. Many people use SVN and this call happens all the time, but this is the first bug report I've seen on this.

Try doing a 'svn info' on the repository from a terminal on the server repeatedly. See where it fails.

Also try turning on logging on Review Board and see what's in the log file when it happens.
david
#6 david
  • -NeedInfo
    +Incomplete