1949: RBtools intermittently not submitting review requests.

mail.*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Sept. 25, 2011 
I've got a SVN commit hook that submits review requests on commits, for the most part this is working as intended but about 10% of our commits are not actually pushed to reviewboard server.
do-review-request-log 
post-review --username=svnuser --password=svnpassword --submit-as=svnusername -p --revision-range=16699:16700 --repository-url=svn://svnrepository/url --summary="Revision: 16700" --description="svnusername 2011-01-18 10:39:51 +0200 (Tue, 18 Jan 2011) 85 SVN Commit message" -d
>>> svn info svn://10.0.1.241/enterpriseapps
>>> diff --version
>>> repository info: Path: svn://10.0.1.241/enterpriseapps, Base path: /, Supports changesets: False
>>> svn diff --diff-cmd=diff svn://10.0.1.241/enterpriseapps/@16699 svn://10.0.1.241/enterpriseapps/@16700
>>> Looking for 'review.dev.net /' cookie in /root/.post-review-cookies.txt
>>> Loaded valid cookie -- no login required
>>> HTTP GETting /api/json/repositories/
>>> HTTP GETting /api/json/repositories/2/info/
commit-hook-log 
root@Apache2:/home/superman# /home/svnadmin/doReviewRequest.sh /home/svnadmin/repos/enterpriseapps 16700
Traceback (most recent call last):
  File "/usr/bin/post-review", line 8, in <module>
    load_entry_point('RBTools==0.2', 'console_scripts', 'post-review')()
  File "/usr/lib/python2.5/site-packages/RBTools-0.2-py2.5.egg/rbtools/postreview.py", line 2861, in main
  File "/usr/lib/python2.5/site-packages/RBTools-0.2-py2.5.egg/rbtools/postreview.py", line 2497, in tempt_fate
  File "/usr/lib/python2.5/site-packages/RBTools-0.2-py2.5.egg/rbtools/postreview.py", line 399, in new_review_request
  File "/usr/lib/python2.5/site-packages/RBTools-0.2-py2.5.egg/rbtools/postreview.py", line 538, in _get_server_info
  File "/usr/lib/python2.5/site-packages/RBTools-0.2-py2.5.egg/rbtools/postreview.py", line 196, in find_server_repository_info
  File "/usr/lib/python2.5/site-packages/RBTools-0.2-py2.5.egg/rbtools/postreview.py", line 212, in _get_repository_info
  File "/usr/lib/python2.5/site-p
david
#1 david 
Can you determine what the bad line it's receiving is?
  • +NeedInfo
#2 mail.*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I'm not sure whether the bad line is caused by the diff or something else as the commit usually goes through after a few retries.
david
#3 david 
Can you dig into the python code, or log the HTTP accesses?
#4 mail.*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I've done so and am waiting for the error to be logged.
#5 mail.*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
My python's not up to scratch so I'm not able to see the exception message using the following code

try:
    rsp = urllib2.urlopen(url).read()
except:
    e = sys.exc_info()[1]
    debug('Error occured %s' % str(e))
    raise e

The url call does however not get to my apache server. I see the call to /api/json/repositories/ but nothing after that.
david
#6 david 
Without any actual debug information, we don't have any way of dealing with this :(

Please reopen if you get more detail about what's going on.
  • -NeedInfo
    +Incomplete