1945: Summary: Incorrect detection of SVN repository relative paths (affects reviews.apache.org)

goo***@astitcher.*********** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
Feb. 8, 2011 
What version are you running?

RBTools 0.2

What operating system are you using? What browser?

Fedora 14

Please provide any additional information below.

The Apache svn instance has one huge repository with every project as a top level directory and the repo root is: https://svn.apache.org/repos/asf

When you pick up the official git mirror its root URL is: https://svn.apache.org/repos/asf/qpid/trunk

https://svn.apache.org/repos/asf/qpid is registered as the url for the repo in reviews.apache.org (which is what you'd expect to allow for reviews of branch code).

Unfortunately the previous relative path detecting code would try to match ['', 'qpid', 'trunk'] with ['', 'qpid'] and fail rather than matching only the same number of components of the path as exist in the root so as to strip of the common prefix and return the actual relative path.

Attached is a patch to fix this bug.

review patch: http://reviews.reviewboard.org/r/1957/
bug.patch 
diff --git a/rbtools/postreview.py b/rbtools/postreview.py
--- a/rbtools/postreview.py
+++ b/rbtools/postreview.py
@@ -231,7 +231,7 @@ class SvnRepositoryInfo(RepositoryInfo):
 
         # If one of the directories doesn't match, then path is not relative
         # to root.
-        if rootdirs != pathdirs:
+        if rootdirs != pathdirs[:len(rootdirs)]:
             return None
 
         # All the directories matched, so the relative path is whatever
chipx86
#1 chipx86
  • +Fixed
  • +Component-RBTools
  • +chipx86