1939: .sj Files are being displayed as binary files (despite being text format files) in review board

rahul******@gmai***** (Google Code) (Is this you? Claim this profile.)
March 21, 2011 
What version are you running - 1.0.9


What's the URL of the page containing the problem - N/A


What steps will reproduce the problem?
1. Submit any diff file which contains .sj files in the code
2. Go to View Diff
3. Review board shows that .sj files are binary files and code doesn't get displayed for these files

What is the expected output - N/A
What do you see instead - N/A


What operating system are you using - All OS
What browser - All Browsers



Thanks & Regards
Rahul
david
#1 david 
Typically this is because your SCM is reporting these files as being binary. Are you sure things are set up right in the repository?
  • +NeedInfo
#2 rahul******@gmai***** (Google Code) (Is this you? Claim this profile.) 
Yes. The repository looks fine to me. We use perforce as the repository.......
chipx86
#3 chipx86 
Review Board itself doesn't make the determination as to whether it's a text file or binary file, so it's definitely coming from your repository or your diff tool.

You can verify this with 'post-review --output-diff <changenum>"
#4 rahul******@gmai***** (Google Code) (Is this you? Claim this profile.) 
I just verfied it..
Looks like there is a problem in the diff tool.
The tool which we are using to generate the diff is "P5".
diff file doesn't contain the text for .sj files....


Thanks for the clarification..
david
#5 david
  • -NeedInfo
    +SetupIssue