19: Retain the cursor position when clicking a diff chunk.
- Fixed
- Review Board
| ads****@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| May 14, 2007 |
What's the URL of the page containing the problem? http://reviewboard.eng.vmware.com/r/12/diff/ What steps will reproduce the problem? 1. Visit URL. 2. Click on "new content" in the change index at the top of the page. 3. Hit PgDn to scroll down the page. 4. Click on the highlighted area. What is the expected output? What do you see instead? The page should not move. But it jumps back down so that the top of that file's section is now aligned with the top of the browser's viewport. What operating system are you using? What browser? Firefox 2.0.x on Feisty. Please provide any additional information below. Clicking on smaller highlighted sections of a diff will trigger this behaviour too.
It's intentional. It's repositioning the arrow on the left-hand side. This is used so that if you press N/P to jump around a bit and then scroll somewhere, you can click an area to update the currently selected chunk. We might be able to set this without scrolling the page, but I wanted to explain what was happening here. I think that's an enhancement though.
-
- Type-Defect - Priority-Medium + Type-Enhancement + Priority-Low + Usability + Component-DiffViewer -
+ Retain the cursor position when clicking a diff chunk.
-
+ Fixed