1893: Fields shouldn't become editable when selecting text or clicking hyperlinks

maxim.******@gmai***** (Google Code) (Is this you? Claim this profile.)
Nov. 25, 2012
2062, 2636
What version are you running?
1.5.1

What's the URL of the page this enhancement relates to, if any?

Review Request

Describe the enhancement and the motivation for it.

I'd like to have all links in summary and description fields to be real links which might be clicked. Now you should edit field, copy link to clipboard and then open it somewhere what not handy

What operating system are you using? What browser?

Any

Please provide any additional information below.
chipx86
#1 chipx86
They are. What have you tried? Can you check if there are JavaScript errors?
  • +NeedInfo
#2 maxim.******@gmai***** (Google Code) (Is this you? Claim this profile.)
You are right. It works for description but not for summary what I need.
chipx86
#3 chipx86
Oh. Well, what do you need it for? I'm honestly not sure I like the idea of having it there.
  • +Links in summary field
#4 maxim.******@gmai***** (Google Code) (Is this you? Claim this profile.)
We are using RP on post-commit basis and after review people making changes and committing code back with link to origin review as comment to commit. Then reviewer may check what was initially requested to be changed. 

It might be not so unhandy but when I'm trying to copy link from summary field switches to edit mode :|
chipx86
#5 chipx86
Yeah, I've noticed the copying thing. That definitely needs to be fixed.
#6 maxim.******@gmai***** (Google Code) (Is this you? Claim this profile.)
Thanks!
david
#7 david
  • -NeedInfo
    +New
  • +Component-Reviews
    +Usability
  • -Links in summary field
    +Fields shouldn't become editable when selecting text.
david
#8 david
  • -Fields shouldn't become editable when selecting text.
    +Fields shouldn't become editable when selecting text or clicking hyperlinks
david
#11 david
Fixed in djblets master (541abb5). Thanks!
  • -New
    +Fixed