1878: post-review does not parse out user from subversion URL: svn://user@svn_repos

jlbr*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Jan. 21, 2014
What version are you running?
1.5

What's the URL of the page containing the problem?

N/A.


What steps will reproduce the problem?
1.  Configure an Subversion repository in Review Board (e.g. svn://svn_repository).
2.  Checkout code from SVN repository using URL with username (e.g. svn co svn://username@svn_repository/...).
3.  Make a file change, and run 'post-review -d'.

What is the expected output? What do you see instead?

I would expect post-review to obtain the svn repository URL information, and build a valid svn command to generate the diff.

The repository path obtained from svn is in the form of: protocol://username@svn_repository.  The resulting svn command that post-review builds fails:
Failed to execute command: ['svn', 'propget', 'reviewboard:url', 'svn://username@svn_repository']
svn: Try 'svn help' for more info
svn: Syntax error parsing revision 'svn_repository'


What operating system are you using? What browser?

Cygwin bash on WinXP Pro SP3.


Please provide any additional information below.

Python 2.5.5, Subversion client 1.6.13
david
#1 david
  • +Component-RBTools
david
#2 david
I believe this has been fixed for a while.
  • +Fixed