1877: hitting ESC when filling out a review description erases the entire description if you haven't hit OK yet

paul.r******@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
Sept. 21, 2011 
What version are you running?
1.0.5.1

What's the URL of the page containing the problem?
n/a

What steps will reproduce the problem?
1. create a new review request
2. spend 5 minutes crafting a detailed description
3. hit ESQ by accident

What is the expected output? What do you see instead?
I expect it not to erase my description

What operating system are you using? What browser?
windows + firefox 3.6.12

Please provide any additional information below.
david
#1 david
  • +Usability
    +Component-Reviews
  • +hitting ESC when filling out a review description erases the entire description if you haven't hit OK yet
#2 ben.h*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
We've had several of our users (vim afficionados, all of them) complain about this too. Since ESC is a pretty common control character in vim, they hit it by accident all the time. Even just throwing up a prompt before canceling would fix this.
#3 kevingoo*********@gmai***** (Google Code) (Is this you? Claim this profile.) 
So... much... rage over this. Why, devs? Why do you hate me so much? Please, please do something about this before my head explodes.
chipx86
#4 chipx86 
We don't hate you. We love you! That's why it was fixed in 1.6 (not closed though I guess). Try upgrading.

I think you can also get the benefit on 1.5.x by just upgrading Djblets.
  • +Fixed
  • +Milestone-Release1.6
  • +chipx86
#5 xelepart 
This is back in the 2.0.20 -- is the standard process to post updates/reopen bugs, or post new ones? :)
#6 xelepart 
oh maybe this isn't talking about the thing I am seeing. I'll file a new bug.