1835: Update Djblets' versions of jQuery and jQuery UI

ben.h*****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
Nov. 24, 2012
What version are you running?
0.6.3

Djblets is using jQuery 1.3.2 and jQuery UI 1.6rc5. It'd be nice if it could upgrade those packages in order to take advantage of the speed and bugfixes of the jQuery 1.4.2 and jQuery UI 1.8.5 releases.
#1 dmitry.n*********@gmai***** (Google Code) (Is this you? Claim this profile.)
Hi,

I'm trying to package reviewboard to Debian and it looks like now this is the latest issue. It can't be shipped with outdated version of jquery/jquery-ui libraries. 

I've already tried to update it to something more recent. Almost everything seems to work without any changes except editing fields (there is no "edit" button at all). And also there are no JS errors. I'm trying to debug it but for now without luck :)

If you have some suggestions, where to look, I'll really appreciate it.

Thanks
chipx86
#2 chipx86
What's the problem with shipping with our bundled jquery libs? It's not like it has a dependency on an external package for them.

Short answer: You're out of luck until we get a chance to do the work needed to move over to that. Many things changed and we're just not ready for it. What we use may be outdated, but it's a compatibility thing at the moment.

If you end up working toward that and making sure everything works (admin UI, diff/screenshot commenting, review request page, user popups, file attachments, basically every single thing that touches JavaScript anywhere) then we can ship it, but don't just bundle the patch :) Otherwise, if anything crops up, we're stuck with a bad support situation.
  • +NeedInfo
#3 dmitry.n*********@gmai***** (Google Code) (Is this you? Claim this profile.)
Hi,

The issue is that using "embedded" copy of well-known JavaScript library violates Debian policy. JQuery and most of surround libraries are already packaged. For example jQuery-UI:

http://packages.debian.org/search?keywords=libjs-jquery-ui

And since it's already packaged, all new packages are required to use it instead of embedded versions.

The same happens with all other code from third-parties (python modules, shared libraries, etc). That's why I'm packaging 1.7 instead of stable release. Just because version 1.6 uses too old version of Django.

As about jQuery. I'm looking to it right now. Even if I'll not be able to fix everything, I'll share my patch. Maybe it'll be useful for somebody who can continue this work. 


Thanks a lot
chipx86
#4 chipx86
Hmm.. Well, we cannot provide any support to customers using jQuery versions other than what we're supporting, so that's going to be a problem. Even if we were made up-to-date with the latest jQuery, all it would take is some regression in a newer version that we have not tested but Debian has upgraded to to break us.

That would be non-obvious and hard to catch, so the question for any such errors in support requests would have to be "Are you using the Debian package? If so, stop using it." I hate to say it, but by modifying our shipped dependencies, we just can't reliably support the package.

To contrast, the Fedora group is packaging Review Board and hasn't modified what we ship, and it's been working out really well. We've been able to provide support for that.

I understand this policy for native libraries. I cannot understand it for webapps, which may have very specific requirements or even modifications to libraries. For example, we use some third-party libraries for AJAX form publishing, but have extensive modifications (allowed by the license). If you were to require use of an external package for that, you would break us.

As for packaging Django, we will not provide any support for anything but an offical, stable release. The 1.7 release *will* fail for anyone upgrading right now, and *will* fail for any updates we make to what you're currently packaging.

If you can't package 1.6.x with Django 1.3.1, I'd suggest not packaging anything right now until we release. It's just a support nightmare for us and for you.
david
#5 david
  • -NeedInfo
    +New
david
#6 david
  • -New
    +Fixed
chipx86
#7 chipx86
We still need to upgrade jquery-ui.
  • -Fixed
    +Confirmed
  • +Milestone-Release1.7
  • +chipx86
david
#8 david
This is done now.
  • -Confirmed
    +Fixed