mconley

1834: GitHub support should accommodate GitHub Organizations

mconley
Dec. 5, 2010 
http://reviews.reviewboard.org/


What version are you running?


1.5RC2


What's the URL of the page this enhancement relates to, if any?

http://github.com/blog/674-introducing-organizations


Describe the enhancement and the motivation for it.


On June 29th, 2010, GitHub introduced organizations for project management.  This changes the permission structure somewhat, and Review Board's GitHub support doesn't let us use it.


What operating system are you using? What browser?


Ubuntu Lucid, Firefox 3.6


Please provide any additional information below.


We've got a workaround with a post-receive hook on GitHub causing a pull on a server-local copy of the repository, so this isn't critical for us.  Just something you might want for the future.
chipx86
#1 chipx86 
Thanks for the info. I wasn't aware of the new Organizations support, but it looks very interesting.

So the GitHub hosting option in Review Board won't work with the Organizations? The raw URL is basically incorrect I assume?

Do you have an organization I can look at that's public?
  • +NeedInfo
  • +Component-SCMTools
    +Milestone-Release1.5.x
mconley
#2 mconley 
Here's our organization:

http://github.com/MarkUsProject

The raw URL is the same - the problem is with authentication.  The MarkUsProject organization has several team members, but I don't think the authentication works the same way.  We kept getting a 500 error.

I don't have too much more information about it - we've implemented our workaround, and we're up and running.

-Mike
chipx86
#3 chipx86 
Okay. I'll look at this for 1.5.1. I want to get RB moved onto this now.
  • -NeedInfo
    +Confirmed
chipx86
#4 chipx86
  • -Priority-Medium
    +Priority-High
chipx86
#5 chipx86 
This seems to have fixed itself. I suspect GitHub's improved the support for backward-compatibility.
  • -Confirmed
    +Fixed
#6 br***@janra****** (Google Code) (Is this you? Claim this profile.) 
I don't believe this is fixed.  I couldn't get it to work.  I doubt private repos work either - the ssh uri for them is:
ssh://github.com:<organization>/<project>.git  but reviewboard tries to connect to them as:
ssh://git@github.com/<organization>/<project>.  SSH authentication succeeds, but github just hangs up since the url is incorrect.
#7 br***@janra****** (Google Code) (Is this you? Claim this profile.) 
I should say this is reviewboard v1.5.5
chipx86
#8 chipx86 
Organizations absolutely work. We use them for a component of Review Board.

Private standalone repos also absolutely work. I use Review Board daily with one of them.

Now, private organizations do not work. There is a patch up for that, though, and we'll be fixing that for 1.5.6.
#9 gustav******@2degreesn********** (Google Code) (Is this you? Claim this profile.) 
Private organizations do work in v1.5.5, but you have to adjust some settings by hand: Once you have created the private repository, you have to edit it to set "Raw file URL mask" to it to something like:

http://github.com/api/v2/yaml/blob/show/ORGANIZATION_NAME/twod/<revision>?login=USERNAME&token=API_TOKEN

Note that you have to replace "ORGANIZATION_NAME", "USERNAME" and "API_TOKEN".
#10 gustav******@2degreesn********** (Google Code) (Is this you? Claim this profile.) 
Sorry, wrong URL. It should be something like:

http://github.com/api/v2/yaml/blob/show/ORGANIZATION_NAME/PROJECT_NAME/<revision>?login=USERNAME&token=API_TOKEN

And you have to replace "ORGANIZATION_NAME", "PROJECT_NAME", "USERNAME" and "API_TOKEN".
#11 gustav******@2degreesn********** (Google Code) (Is this you? Claim this profile.) 
I forgot to mention that the problem is that Review Board sets USERNAME to ORGANIZATION_NAME, ignoring whatever you put in the form for the username.