1823: reports an XML file as binary when it is text.

cppg****@gmai***** (Google Code) (Is this you? Claim this profile.)
Oct. 12, 2010 
What version are you running? 1.0.7


What's the URL of the page containing the problem? http://cm1/reviews/r/26/diff/#index_header


What steps will reproduce the problem?
Not sure exactly, but:
1. create an XML file (see attached)
2. use hg postreview to create the diff
3. view in RB (see screenshot.png)
3.

What is the expected output? What do you see instead?
I expected a diff for a text file. RB indicates it is binary.

What operating system are you using? What browser?
Ubuntu 10.04, Google chrome


Please provide any additional information below.
david
#1 david 
What type of repository is this?
  • +NeedInfo
#2 cppg****@gmai***** (Google Code) (Is this you? Claim this profile.) 
It's mercurial.

Looks like mercurial calls it "binary" to prevent merging from occurring. Any way to get reviewboard to override this and treat it as text anyway?
chipx86
#3 chipx86 
If it's part of the diff, we're out of luck. We're doing what we're told to do from the diff.
#4 cppg****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Understood. 

Well there's luck for you :)  Thanks anyway.
david
#5 david
  • -NeedInfo
    +ThirdParty