1811: Failing to publish each diff comment forgets them when publishing the whole diff.

nek****@gmai***** (Google Code) (Is this you? Claim this profile.)
Sept. 26, 2010
831 
What version are you running?
1.0.9

What's the URL of the page containing the problem?
https://<host>/reviews/r/<#>

What steps will reproduce the problem?
1. post-review
2. submit information
3. view diff
4. enter comments
5. publish review

Failing to publish each diff comment forgets them when publishing the whole diff.  Hitting publish once should publish everything in the current review at once....  

Had I done a post-review -r <#> and not published that, how could I publish the comments?  If someone wants to publish the update then each comment, thats fine.  But, should someone not want to invite questions they are about to answer by publishing the update and the comments together, it cannot be done.

What is the expected output? What do you see instead?


What operating system are you using? What browser?


Please provide any additional information below.
chipx86
#1 chipx86 
I don't understand. Are you typing the comment and then clicking another line number, without ever hitting Save in the diff comment dialog?
  • +NeedInfo
david
#2 david 
This actually sounds exactly like bug 831.
#3 nek****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I am guessing I hit save.

Now, I do:
1. post-review
2. submit information
>>> publish review
3. view diff
4. enter comments
>>> I believe I always hit save
5. publish review

And this works.  Next chance I get, I will try this again without the publish review after step 2 but making sure I always hit save.

I also remember that when I did this the way as initially listed, I got brown boxes at the top of the page under the green box asking if I'd like to publish telling me there was an error.  But, its been a while.