180: "replying" to previous comments in the diff viewer is confusing
- Fixed
- Review Board
| grossag | |
 |
|
| Jan. 20, 2008 |
Using Windows XP with Firefox 2.0.0.6. I sent out a review request and got some comments. In responding to those comments, I hit "View Diff" and just responded inline there. When I clicked "View Review Request" and looked at the last review that I was responding to, I did not see my comments below each of theirs. The reason why this would be nice to fix is to have an easier way to determine if I have responded to all comments.
Responding to comments via the diff viewer will create a separate review, which probably isn't what you want when you're replying to someone else's comments. The way to do a true reply is to use the "Add comment" links in the review page. The workflow is a little unclear right now, and I know this has confused other people.
-
+ "replying" to previous comments in the diff viewer is confusing
-
+ Usability + Component-DiffViewer
> Fixed in SVN. Is it? I installed yesterday's SVN sources (r1373) and adding comment to existing comment in diff view does not make it a reply, it's still added as independent comment.
The existing discussion is in a separate tab, which points people towards the review request page. This bug was filed because the previous design of the pop-up dialog strongly suggested that it was creating a reply when it was creating a new comment.
7 years later this is still a problem. Clicking on the "Reply" button in diff view creates a separate comment, but users expect it to add a comment below an existing comment (as if they'd pressed the "Add comment" button below an existing comment in the "Reviews View"