1797: Creation of new review request fails if diff file has accents in the header (line 3) - (révision 123)

mbou****@matro***** (Google Code) (Is this you? Claim this profile.)
Nov. 6, 2010
What version are you running?

1.5 RC1

 

What's the URL of the page containing the problem?

New Review Request - Subversion

 

What steps will reproduce the problem?

1.Use Subversion in French (or any other language that has accents)

2.Create a patch file - The header of the file will have the word "révision" instead of "revision"

3.You will get an error message on the next page saying it can read the header file. Any accents later in the patch file seems to work fine.

 

What is the expected output? What do you see instead?

The creation of the new review fails.

 

What operating system are you using? What browser?

XP, Firefox

 

Please provide any additional information below.
chipx86
#1 chipx86
This is an annoyance of Subversion's diff generation. They translate fields that should not be translated. We work around this in our post-review script, which I recommend using instead of svn diff.
david
#2 david
  • +UserError