1794: alert (popup) the user when attempting to leave a page with unpublished changes
- Fixed
- Review Board
| assaf*****@gmai***** (Google Code) (Is this you? Claim this profile.) | |
 |
|
| June 30, 2011 | |
| 1706, 2067, 2150 |
Often I find myself navigating away from a review page without having published my changes. It's nice that there's this "draft" feature, and in a few cases I do mean to navigate away without submitting (yet). However, my impression is that most of the time I find these drafts hiding all over the place because people just closed the browser or navigated away by accident. The system should have a (configurable) option to alert the user "did you forget to publish?".
-
+ Component-Reviews
-
+ Confirmed -
- Priority-Medium + Priority-Critical + Milestone-Release1.6 -
+ chipx86
-
- Confirmed + PendingReview
-
- PendingReview + Fixed
In case my comment on issue 2150 gets otherwise ignored (http://code.google.com/p/reviewboard/issues/detail?id=2150#c2), while it is nice that the issue of leaving a page with unpublished changes is resolved, issue 2150 is about unSaved changes, not unpublished changes. As such, comment 4 here, which is about merging in issue 2150, should not have been done. It appears that issue 1706 and issue 2067 are also about losing unsaved changes in the same way.
I think there was some confusion all around. Both issues are now fixed. For upublished changes, we don't warn, but the draft banners are much more apparent. For unsaved changes, we'll warn before navigating away from the page.
Glad to hear it. Thanks for the clarification.