1788: Updating a review before it's published wipes out unpublished comments

ben.h*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Aug. 29, 2010
What version are you running?
1.0.3, RBTools 0.2

What steps will reproduce the problem?
1. Create a review with post-review
2. Add comments to the code and save them (but you can't publish yet of course)
3. Update the review with new code using post-review

What is the expected output? What do you see instead?
I'd expect to see the comments that were already there still there, or a warning that they'd be removed from post-review. Instead, the saved-but-unpublished comments are wiped out silently.
chipx86
#1 chipx86
So you're commenting on a draft diff?

That's actually a bug that you can even do that. We've since fixed the bug, and you can't even comment on the diff unless it's published.
  • +WontFix