1780: diffs that are only indentation related (with tabs) are not visible in review (download diff is fine)
- Duplicate
- Review Board
| Chris******@actia***** (Google Code) (Is this you? Claim this profile.) | |
| eduardo********@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Sept. 26, 2010 | |
What version are you running? I'm runing 1.0.5.1, also seen in 1.5 RC1 on http://reviews.reviewboard.org What's the URL of the page containing the problem? http://reviews.reviewboard.org/r/1744/diff What steps will reproduce the problem? 1. Modify existing code to change indentation (e.g. tab in first column) 2. gen diff 3. post to reviewboard What is the expected output? What do you see instead? Expect to see diffs, instead see nothing (well empty diffs) What operating system are you using? What browser? FF and chrome Please provide any additional information below. NA?
-
+ Confirmed -
+ eduardo********@gmai***** (Google Code)
Can you go into more detail please? * Where is this option? Repo, global, or user setting? * What version of Reviewboard is this option in? I've not found any options in my 1.0.5.1 server (as an admin or a regular user). With the reported bug demo http://reviews.reviewboard.org/r/1744/diff I can't see any options that I can change as a regular user (non-admin) In 1.0.5.1 there is a "show all white space for" (file types) in the Diff view settings (for admin user), is this the setting you mean? Thanks!
As a quick update, for the (internal) review my user was complaining about, adding "*.py" (no quotes)) to the 1.0.5.1 global, Admin, "Settings", "Diff Viewer" settings "show all white space for" field fixed the problem I had
-
- Confirmed + Duplicate -
+ 1511 - Diffs containing only indentation changes causes the diff viewer to look empty