1773: Perform an existence check when adding a user to a code review

ben.h*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Oct. 21, 2010
What version are you running?
1.0.3

What's the URL of the page containing the problem?
Review page

What steps will reproduce the problem?
1. Click to edit the reviewers field
2. Type the name of somebody who's not a user
3. Hit save

What is the expected output? What do you see instead?
I'd expect an error or something saying that the user didn't exist. Instead they're silently removed.
chipx86
#1 chipx86
  • +Confirmed
  • -Priority-Medium
    +Priority-Low
    +Milestone-Release1.5.x
    +Component-Accounts
    +Component-Reviews
    +BetterErrors
    +Usability
david
#2 david
Fixed on master (for 1.6) as revision cfa2660. Thanks!
  • -Confirmed
    +Fixed