1769: Newlines in review summary cause ReviewBoard to error

ben.h*****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
chipx86
Nov. 10, 2010
What version are you running?
1.0

What's the URL of the page containing the problem?
The view-review page (internally hosted instance)

What steps will reproduce the problem?
1. Using post-review, create a review with a summary that has newlines in it.
2. Open up the review in your browser.
3. Try to publish the review.

What is the expected output? What do you see instead?
I'd expect the review to publish. Instead, I'm given an error dialog. I can work around the problem by editing the summary to remove newlines and then publishing. The error looks something like this:

BadHeaderError: Header values can't contain newlines (got u'Review
Request: First line commit 1\nFirst line commit 2' for
header 'Subject')

Issue 1689 seems to be a specific case of this.

What operating system are you using? What browser?
FF 3.6/Windows. ReviewBoard hosted on RedHat Enterprise Linux 5.
chipx86
#1 chipx86
Hmm, thought we explicitly checked for that. What version is this? 1.0.what?
  • +NeedInfo
#2 ben.h*****@gmai***** (Google Code) (Is this you? Claim this profile.)
We're using 1.0.3.
chipx86
#3 chipx86
Okay, that version is quite old, but it's possible that this bug is still around. Thought we had fixed it though. I'll take a look.
  • -NeedInfo
    +New
  • +Milestone-Release1.0.x
    +Component-Reviews
  • +chipx86
#4 ben.h*****@gmai***** (Google Code) (Is this you? Claim this profile.)
I haven't seen this since we upgraded to 1.5. I'm guessing it's fixed.
david
#5 david
Good to know, thanks.
  • -New
    +Fixed