1756: Download Diff button doesn't download the diff file in Safari

emai*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Aug. 30, 2010 
What version are you running?
1.0.9

What's the URL of the page containing the problem?
http://private/codereviews/r/1/

What steps will reproduce the problem?
1. View a review in Safari 5.0.1 on Mac OS X 10.6.4.
2. Click the Download Diff button.

What is the expected output? What do you see instead?
I expected Safari to download the diffs as a file, and not change the viewed page.  Instead, the viewed page changes to http://private/codereviews/r/1/diff/raw/ , and the diffs are viewed as a text file in Safari.

What operating system are you using? What browser?
Mac OS X 10.6.4, Safari 5.0.1.
david
#1 david 
We give the file type as text/x-patch (which is correct). If safari wants to display that, there's not much we can do about that.
  • +ThirdParty