1753: post-review problem with mercurial

rigo*****@gmai***** (Google Code) (Is this you? Claim this profile.)
Nov. 7, 2010
Reviewboard 1.5 RC1
RBTools 0.2
Windows XP
WampServer2.0i
Python 2.6.5

The problem does actually regard the RBTools' post-review tool.
Repository is used with Mercurial 1.6.2

What steps will reproduce the problem?

While trying to post a review from a branch which is not on the server. 
Using the "--parent" + the "--revision-range" option.
Posting a review request this way only works, if the parent changeset is next to the "--revision-ranges"'s start changeset.

for example: 

post-review --server=http://localhost/ --revision-range=17:40 --parent 16
would work

whilst:
post-review --server=http://localhost/ --revision-range=18:40 --parent 16
would not work.
david
#1 david
It sounds to me like this is exactly what I'd expect. The whole point of the parent changeset is so that your diff will apply cleanly. If there are missing changes, we can't guarantee that it will.
  • +NotABug