1751: memcache broken with Control Characters not allowed

ale***@gmai***** (Google Code) (Is this you? Claim this profile.)
Dec. 16, 2010
What version are you running?
1.09 and 1.5 RC1

What's the URL of the page containing the problem?
View Diff for a review request (the diff file is attached)

What steps will reproduce the problem?
1. Bzr repository
2. Create new review request, upload the attached the diff file
3. View Diff broken, complaining memcached key "Control Character not allowed"

What is the expected output? What do you see instead?
Instead of the diff, I see error dump.

What operating system are you using? What browser?
Linux 64-bit, ubuntu 10.04, firefox

Please provide any additional information below.
I have to disable memcache for now
#1 ale***@gmai***** (Google Code) (Is this you? Claim this profile.)
Seems a bug with python-memcache lib not escaping the key.
david
#2 david
I know it's been a little while, but can you add the backtrace that you're seeing to this report?
  • +NeedInfo
david
#3 david
  • -NeedInfo
    +Incomplete