1747: post-review --revison-range=XXXXX crashes (implement post-commit posting)

codemo*******@gmai***** (Google Code) (Is this you? Claim this profile.)
March 21, 2011
921
What version are you running?

RBTools 0.2

What's the URL of the page containing the problem?

N/A

What steps will reproduce the problem?

1. post-review --revison-range=XXXXX

What is the expected output? What do you see instead?

I expect this to create a post-checkin review with diff for change list specified.

Instead it crashes with the following stack trace:

Traceback (most recent call last):
  File "C:\Python26\Scripts\post-review-script.py", line 9, in <module>
    load_entry_point('RBTools==0.2', 'console_scripts', 'post-review')()
  File "C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools\postreview.p
y", line 2861, in main
    submit_as=options.submit_as)
  File "C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools\postreview.p
y", line 2554, in tempt_fate
    parent_diff_content)
  File "C:\Python26\lib\site-packages\rbtools-0.2-py2.6.egg\rbtools\postreview.p
y", line 503, in upload_diff
    debug("Uploading diff, size: %d" % len(diff_content))
TypeError: object of type 'NoneType' has no len()

What operating system are you using? What browser?

Windows XP SP3.
P4 Server 2005.1/89985.
Safari

Please provide any additional information below.

I am trying to set up to evaluate Review Board for use with a post check-in workflow using P4 source control on a large project.
david
#1 david
If you're just submitting a single revision with p4, you don't need --revision-range, you can just pass the change number as the argument. That said, we should fix this so both work.
  • +Component-RBTools
david
#2 david
Oh, actually, looking more closely at your report, post-commit workflows won't work with p4 and post-review. We don't yet have the capability to fetch diffs from the server, only to get them from the working copy.
  • -Type-Defect
    +Type-Enhancement
  • +post-review --revison-range=XXXXX crashes (implement post-commit posting)
chipx86
#4 chipx86
  • -reviewboard
    +rbtools
  • -Component:RBTools