1722: UTF-16 file from Perforce not displayed

AaronJ*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 4, 2014 
What version are you running?

  1.0.9

What's the URL of the page containing the problem?

  Not available to public

What steps will reproduce the problem?
1. In Perforce, "p4 add -t utf16" a new file in UTF-16 encoding
2. p4 change and post-review the new file
3. View in ReviewBoard

What is the expected output? What do you see instead?

  New file contents should display

  Note: In theory, UTF-16 diffs can be re-encoded and displayed as UTF-8

What operating system are you using? What browser?

  Linux/Firefox

Please provide any additional information below.

This seems to be related to issue #1326 which was closed as user-error, but in this case, the VCS and does know that the file is UTF-16.

I also tried Perforce type xutf16. Same results.

Attaching my test file.
#1 AaronJ*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
Any word on a fix for this (hopefully in the 1.0.x series, but at this point, I'd take anything I could get)?
#2 joshua*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
For the record, it doesn't look like this is fixed in 1.5.
david
#3 david 
It would be nice if you explain what you're seeing instead.
  • +NeedInfo
#4 joshua*******@gmai***** (Google Code) (Is this you? Claim this profile.) 
It just shows "This is a binary file, contents cannot be displayed" or whatever it usually does when encountering a binary file.
david
#5 david
  • -NeedInfo
    +New
#6 eyu****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Just for the record. It is not fixed as of 1.6.1. I'm using latest RBTools (0.3.4)
#7 seagl*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I got the same issue in 1.6.3. Will it be fixed?
#8 jia***@gmai***** (Google Code) (Is this you? Claim this profile.) 
It doesn't work with UTF-16 files with Subversion as well. I guess it is not Perforce specific problem. I'm using ReviewBoard 1.6.9.
david
#9 david
  • +Component-RBTools
    +Component-SCMTools
grossag
#10 grossag 
I would love to see this fixed as well.  Visual Studio 2008 requires that files either be ANSI or UTF-16 so for localized resource files we need to use the UTF-16 file type.  However, this doesn't work with reviewboard so I will have to jump through a bunch of hoops to get Visual Studio 2008 to work with UTF-8 resource files.
david
#11 david 
This is generally fixable by setting utf-16 as a possible encoding for the repository.
  • -New
    +SetupIssue