1708: Allow people to override hgrc

gordon.m********@gmai***** (Google Code) (Is this you? Claim this profile.)
Jan. 22, 2014
2765 
What version are you running?

post-review 0.2.1 alpha 0

What steps will reproduce the problem?
1. Post a review using post-review in a case where relevant .hgrc is not trusted by Mercurial -- see http://www.selenic.com/pipermail/mercurial/2006-October/011550.html
2. Summary contains two concatenated error messages: "Not trusting file /path/to/.hg/hgrc from untrusted user user1, group group1 Not trusting file /path/to/.hg/hgrc from untrusted user user1, group group1"

Should instead see a proper summary, or something other than smushed-together error messages.
#1 gordon.m********@gmai***** (Google Code) (Is this you? Claim this profile.) 
I'm going to amend this -- post-review doesn't appear to be using the global .hgrc in ~/.hgrc, because in the above example, user1 and group1 are listed as trusted there.

The title of this bug should be changed and the priority bumped a bit higher accordingly, it's less than just cosmetic.
#2 gordon.m********@gmai***** (Google Code) (Is this you? Claim this profile.) 
...This also appears in the description.  Sorry about the rapid fire posting, but I forgot to mention that fact and that this applies to --guess-summary and --guess-description.
david
#3 david
  • +Component-RBTools
david
#4 david 
Combining this with another bug:

What we ought to do here is continue ignoring hgrc generally, but allow people to specifically point to an hgrc file in their .reviewboardrc
  • +Allow people to override hgrc
david
#5 david
david
#6 david 
This is fixed in rbtools master. We now use an hg extension to ensure that diffs are created correctly, and so we no longer ignore the users' hgrc entirely.
  • +Fixed