1701: Punctuation characters highlighted with red border in .inc files containing PHP
- Duplicate
- Review Board
| gordon.m********@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Sept. 23, 2010 | |
What version are you running? 1.5 beta 2 What steps will reproduce the problem? 1. Create a diff including .inc files containing PHP code. When viewing the diff, characters such as ', $, : and ? are highlighted with a red border, which is visually disruptive. The characters should not be highlighted.
This may be because the default Pygments "lexer" for *.inc files is the PovrayLexer.
>>> pygments.lexers.get_lexer_for_filename('a.inc')
<pygments.lexers.PovrayLexer>
If Review Board does any file type detection magic, perhaps Pygments could be told to use the proper lexer.
Unsatisfying workaround: disable syntax highlighting altogether.
We don't do any kind of detection. Pygments has this capability but we've turned it off because it's extremely slow. Because that detection would fix this, I'm going to call this the same as issue 337.