1676: bzr repos with local absolute path fails to be created

jan.kn******@gmai***** (Google Code) (Is this you? Claim this profile.)
Nov. 6, 2010
What version are you running?
1.0.8 and 1.5b2

What's the URL of the page containing the problem?
admin -> repositories -> new repo -> bzr 

What steps will reproduce the problem?
1. register a bzr repo with a local, absolute path
2.
3.

What is the expected output? What do you see instead?

reviewboard .strip()s the path which also removes the leading / which later
leads to prepending the 'cwd' of the webserver to it. 

Use .rstrip() instead to only strip the trailing / from the path.

What operating system are you using? What browser?
MacOS X

Please provide any additional information below.

--- reviewboard/scmtools/bzr.py 2010-05-12 09:31:05.000000000 +0200
+++ .../ReviewBoard-1.0.8-py2.6.egg/reviewboard/scmtools/bzr.py    
2010-06-07 11:55:52.000000000 +0200
@@ -65,7 +65,7 @@
 
     def _get_full_path(self, path, basedir=None):
         """Returns the full path to a file."""
-        parts = [self.repository.path.strip("/")]
+        parts = [self.repository.path.rstrip("/")]
 
         if basedir:
             parts.append(basedir.strip("/"))
david
#1 david
This was fixed in e6004a40, which is in 1.5 final.
  • +Fixed