1672: ReviewBoard hide existing revisions
- UserError
- Review Board
| Jan.Ko*******@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| Oct. 8, 2011 |
What version are you running? 1.5 beta 3 What's the URL of the page containing the problem? http://SERVER/r/NUMBER/diff/#index_header What steps will reproduce the problem? 1. Turn on view diff 2. 3. What is the expected output? What do you see instead? Diffviewer should show all files. I see only last one. Strange because in HTML source of file I see all files and downloading raw diff show all three files. Also turning off JavaScript work. But when JS is turn on only last file is show. What operating system are you using? What browser? Linux Please provide any additional information below. This doesn't work on 1.5 beta 2 also.
Nothing has changed in the logic anywhere regarding the diff file display. It always shows the first file it will display (generated during the initial page render) and then asynchronously downloads the other files. What do you mean when you say turning off JavaScript works? You see all three files? Can you check your JavaScript debug output to see what errors are being displayed? It's most likely that something is erroring out and preventing further operations for the file display.
-
+ NeedInfo -
+ Component-DiffViewer
I refresh page with firebug turned on. I get something like that (in attachment).
-
+ 
I still don't know what is happen but I make a little investigation. There is reviewboard/diffviewer/views.py:view_diff_fragment():line 218 'standalone': chunkindex is not None and for some reason for this two files chunkindex is None. But I don't know why.
-
- NeedInfo + New
After trying to figure this out for quite some time, the only thing I can think of is if parts of the diff are empty (for example, in an interdiff when some files don't change, or when posting things like perforce changesets that include non-modified files). If you can figure out better what's going on, we can reopen.
-
- New + UserError