1670: post-review does not support UTF-8 in patch files

tag****@gmai***** (Google Code) (Is this you? Claim this profile.)
March 21, 2011 
What version are you running?
0.2rc1

What steps will reproduce the problem?
1. Add a line to a file which is not ascii
2. Attempt to run post-review

Please provide any additional information below.
Traceback (most recent call last):
  File "/usr/local/bin/post-review", line 8, in <module>
    load_entry_point('RBTools==0.2rc1', 'console_scripts', 'post-review')()
  File "build/bdist.linux-x86_64/egg/rbtools/postreview.py", line 2774, in main
  File "build/bdist.linux-x86_64/egg/rbtools/postreview.py", line 2480, in
tempt_fate
  File "build/bdist.linux-x86_64/egg/rbtools/postreview.py", line 503, in
upload_diff
  File "build/bdist.linux-x86_64/egg/rbtools/postreview.py", line 622, in
api_post
  File "build/bdist.linux-x86_64/egg/rbtools/postreview.py", line 597, in
http_post
  File "build/bdist.linux-x86_64/egg/rbtools/postreview.py", line 656, in
_encode_multipart_formdata
UnicodeDecodeError: 'ascii' codec can't decode byte 0xe2 in position 40964:
ordinal not in range(128)
#2 seagl*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
I got this error, too. I am using RBTools 0.2
david
#3 david
  • +Component-RBTools
#4 solg****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Same error here with RBTools0.3
chipx86
#5 chipx86 
Are you sure it's UTF-8? We see people post actual UTF-8 all the time.
  • +NeedInfo
chipx86
#6 chipx86 
If someone can give us a change to our tree that reproduces this with post-review, that will greatly help.
david
#7 david
  • -NeedInfo
    +Incomplete