167: Diff within a line partially working?

regis.d*******@gmai***** (Google Code) (Is this you? Claim this profile.)
david
 david
July 20, 2007 
What's the URL of the page containing the problem?
http://reviewboard.eng.vmware.com/r/1180/diff/#0.1

What steps will reproduce the problem?
1.
2.
3.

What is the expected output? What do you see instead?
Look at the change at line 723-725: on line 723, what has changed on the line is properly highlit 
(yellow background). On line 724, it isn't.

What operating system are you using? What browser?
Irrelevant

Please provide any additional information below.
david
#1 david 
We threshold the results to avoid highlighting if most of the line has changed (since
inter-line diffs are most useful when the change is very small(.  Unfortunately, the
thresholding will never be perfect.  If you've got a patch that improves it, I'm
willing to look ;)
  • +WontFix
  • +Component-DiffViewer
  • +david