164: Add an optional checklist for reviewers to check off
- New
- Review Board
mie***@gmai***** (Google Code) (Is this you? Claim this profile.) | |
It would be nice if there was a way to add a project-specific checklist to each review for things like 'complex algorithms are well-explained', 'no trailing whitespace', 'version history is updated to reflect changes', 'corner cases are explained', 'new C struct definitions must have accompanying create/free functions', 'no loop bodies greater than 200 lines', and so on. It's not that the reviewers wouldn't know these things, but they may forget certain aspects and the checklist will remind them. Obviously, projects not interested would disable this feature.
+1 for option to turn of the trailing whitespace visual warnings (i.e., the red blocks). Even if it's not on a per- project basis, it'd be handy for our group.
Reviewers really seems to forget about the easy guidelines, and I've notice a few of them, while great codes, sometimes forget about Coding Guidelines and such. This would be a really neat improvement.
schapht, I don't think that was in the request. It was just a request for a checklist that reviewers could be asked to complete before signing off on a review.
I like this an idea with "optional checklist for reviewers". We have the same problem and quality team suggest to implement this future on a review dashboard.