1576: my code review requests are listed under "incoming" on my dashbaord
- WontFix
- Review Board
allyo******@gmai***** (Google Code) (Is this you? Claim this profile.) | |
Sept. 30, 2010 |
What version are you running? 1.0.5.1 What's the URL of the page containing the problem? /dashboard/ What steps will reproduce the problem? 1. start a review request 2. add a group that you belong to in the "Groups" list (under "Reviewers") 3. publish the review request 4. go to the dashboard What is the expected output? What do you see instead? Expected -------- The dashboard does not list the review request that was just created. Actual ------ The new review request should not be listed. What operating system are you using? What browser? Windows XP Firefox 3.6.2 Please provide any additional information below. I considered filing this as an "enhancement", but behavior just seems wrong, because it seems that the point of the "incoming" tab is to list code changes that someone _else_ wants me to comment on. Also, if I created the review request, it is considered "outgoing", which means that such review requests are considered incoming and outgoing. Finally, I really don't need to be alerted about requests that I've created (I obviously know about those), unless someone has actually responded to them. In that case, the thing that I want to be alerted of is their response, not my original request.
Actual should have said "The new review request <strike>should not be</strike> is listed." Sorry about that. Wish the ticket form had a "preview" button.
I'm not going to WontFix this just yet, as I'm willing to open this for debate, but it's likely that we're not going to change this behavior. Incoming is to anything going to you directly or to a group you're in. You're seeing it because you're in the group. Actually, I find that I use Incoming (as it's the default dashboard view) to see not only other review requests I need to review but also to see a brief status of my own review requests without having to switch back and forth between Incoming and Outgoing. Pretty sure this is common usage, and changing this will likely disrupt the workflow that many people use.
Thanks, chipx86. Here are some more reasons: Isn't seeing such a mixed list the purpose of the "All My Requests" tab? Similarly, if I'm interested in my own review requests but not others', isn't that what the "Outgoing" tab is for? For me, my own review requests are pure noise when the appear in the "Incoming" list. Imho, the point of the "Incoming" tab is to draw my attention to everything that needs it. My own review requests are a distraction, because if I ever felt that I should have done a change differently, I wouldn't need to make a recommendation to myself to do it. I'd just go ahead an implement the improvement (and possibly ask others to review the subsequent change). Also, if I have no pending review requests, I want that list to be empty so I can quickly tell that nothing requires my attention. Instead, I have to scan through the list only to notice that everything there was sent from me. It's typically the case that one is in a group that one sends a review request to, which means your own reviews practically always show up in your "Incoming" tab whenever you use the "Groups" field. On the other hand, if you send a review request to a bunch of individuals (usually a subset of your teammates), the review request will not appear in the "Incoming" tab (unless you made the mistake of sending the review request to yourself). This seems like an arbitrary distinction for determining which of my review requests will show up in my "Incoming" tab.
Looking at my previous comment, the point of my last paragraph isn't really coming through: regardless of whether you want it, your own review requests will show up under "Incoming" if you use the "Groups" field. If you really want your review request to show up there, it should be pretty easy to force it by list yourself as an individual reviewer. Showing up in the "Incoming" tab should not be the default behavior when you list a group that you happen to be a member of, as is typical when groups correspond to teams, and you want someone on your own team to look at your changes.
I don't think it should be a defect, maybe an enhancement. But I prefer the current behavior.
Seeing as there's a lot of argument both ways, and a lot of people are happy with the current behavior (more than just lonico), I don't think it makes sense to change it just for the sake of changing it.
-
+ WontFix
At this point, there doesn't seem to be a whole lot of support for my idea, but to be clear, I'm not asking for change "just for the sake of changing it". I still think this would be a valuable improvement, even if there aren't too many others advocating for it.