1569: Code review linebreaks are not preserved in all views (i.e. mail)

o3s****@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
May 6, 2010 
What version are you running?
1.5 Beta

What's the URL of the page containing the problem?


What steps will reproduce the problem?
1.Create a review
2.Range select some lines in the diff-view
3.enter some sort of list into the popup with linebreaks

What is the expected output? What do you see instead?
line breaks should be preserved in all views; 
 -> the review index
 -> notification mails

What operating system are you using? What browser?


Please provide any additional information below.
chipx86
#1 chipx86 
I'm afraid I need more details. Can you show some examples or maybe screenshots of
what you're expecting?
  • +NeedInfo
#2 o3s****@gmai***** (Google Code) (Is this you? Claim this profile.) 
tried to add a demo comment to 
http://demo.reviewboard.org/r/44/
I hope you're getting the mail for this one?
#3 o3s****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Heres a screenshot of a mail inside a webmailer (citadel.org)
But i've seen the same in Outlook.
#4 o3s****@gmai***** (Google Code) (Is this you? Claim this profile.) 
any more information needed for this?
chipx86
#5 chipx86 
There's a patch pending for this that will be in the next beta.
  • -NeedInfo
    +PendingReview
  • +Milestone-Release1.5
    +Component-EMail
chipx86
#6 chipx86 
Fixed on master (fc85106)
  • -PendingReview
    +Fixed
  • +chipx86
#7 veste*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
The review description field wraps long lines in the browser => I'm used to just
typing and having the text wrapped. 

In the sent out emails, the description is not wrapped (at least on my lotus notes
web client), causing very wide emails. My html/css has gone a bit rusty, but telling
the pre's to break if necessary seems to do the trick. I've added the following to 
email_base.html:
 <header>
   <style type="text/css">
     pre {
     overflow-x: auto; /* Use horizontal scroller if needed; for Firefox 2, not
needed in Firefox 3 */
     white-space: pre-wrap; /* css-3 */
     white-space: -moz-pre-wrap !important; /* Mozilla, since 1999 */
     white-space: -pre-wrap; /* Opera 4-6 */
     white-space: -o-pre-wrap; /* Opera 7 */
     /* width: 99%; */
     word-wrap: break-word; /* Internet Explorer 5.5+ */
     }
   </style>
 </header>

The css is from here:
http://www.longren.org/2006/09/27/wrapping-text-inside-pre-tags/. There might be a
better way of achieving the same ...
chipx86
#8 chipx86 
Fixed on master (5344e92)