1566: Posting new diff returns error page even though it seems to work

chris.a.********@gmai***** (Google Code) (Is this you? Claim this profile.)
Sept. 26, 2010 
What version are you running?
1.5 beta 1

What's the URL of the page containing the problem?
http://reviews.aptana.local/r/new/

What steps will reproduce the problem?
1. Generate a diff file.
2. Post it to generate a new review request manually.
3. Returns back an error page, even though the request is created.

Seems to be related to default reviewers and a regexp compile error:

Request Method:	POST
Request URL:	http://reviews.aptana.local/r/new/
Exception Type:	error
Exception Value:	
nothing to repeat

Traceback that seems to matter is /usr/lib/python2.5/site-
packages/ReviewBoard-1.5beta1-
py2.5.egg/reviewboard/reviews/models.py in add_default_reviewers

Our settings have one user set up as default review for *.py files. The diff 
contains no python files.

What is the expected output? What do you see instead?


What operating system are you using? What browser?


Please provide any additional information below.
david
#1 david 
Sorry, this seems to have slipped through the cracks. Do you have the full error and traceback? We can't do much without that.
  • +NeedInfo
david
#2 david
  • -NeedInfo
    +Incomplete
#3 asa***@gmai***** (Google Code) (Is this you? Claim this profile.) 
I'm seeing this error too... Here is a traceback

Traceback (most recent call last):

  File "/usr/lib/pymodules/python2.6/django/core/handlers/base.py", line 92=
, in get_response
    response =3D callback(request, *callback_args, **callback_kwargs)

  File "/usr/local/lib/python2.6/dist-packages/Djblets-0.6.4-py2.6.egg/djbl=
ets/auth/util.py", line 46, in _checklogin
    return view_func(request, *args, **kwargs)

  File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5-py2.6.egg/re=
viewboard/reviews/views.py", line 68, in new_review_request
    parent_diff_file=3Drequest.FILES.get('parent_diff_path'))

  File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5-py2.6.egg/re=
viewboard/reviews/forms.py", line 217, in create
    review_request.add_default_reviewers()

  File "/usr/local/lib/python2.6/dist-packages/ReviewBoard-1.5-py2.6.egg/re=
viewboard/reviews/models.py", line 327, in add_default_reviewers
    regex =3D re.compile(default.file_regex)

  File "/usr/lib/python2.6/re.py", line 190, in compile
    return _compile(pattern, flags)

  File "/usr/lib/python2.6/re.py", line 245, in _compile
    raise error, v # invalid expression

error: nothing to repeat
#5 vbe****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Check the default reviewers File regex
#6 vikto*****@gmai***** (Google Code) (Is this you? Claim this profile.) 
Thanks, dude! Very nice! You're great!