1561: post-review: obscure error if the review id is invalid

nah****@gmai***** (Google Code) (Is this you? Claim this profile.)
Aug. 7, 2013
What version are you running?
post-review 0.8

Describe the enhancement and the motivation for it.
If one calls post-review with an invalid review id
(-r/--review-request-id), post-review fails with an obscure error:

Traceback (most recent call last):
  File "/usr/bin/post-review", line 9, in <module>
    load_entry_point('RBTools==0.2rc1', 'console_scripts', 'post-review')()
  File
"/usr/lib64/python2.6/site-packages/RBTools-0.2rc1-py2.6.egg/rbtools/postreview.py",
line 2808, in main
    submit_as=options.submit_as)
  File
"/usr/lib64/python2.6/site-packages/RBTools-0.2rc1-py2.6.egg/rbtools/postreview.py",
line 2500, in tempt_fate
    die("Error getting review request %s: %s" % (options.rid, e))
  File
"/usr/lib64/python2.6/site-packages/RBTools-0.2rc1-py2.6.egg/rbtools/postreview.py",
line 128, in __str__
    if 'err' in self.rsp:
TypeError: argument of type 'NoneType' is not iterable
david
#1 david
  • +Component-RBTools
david
#2 david
This is much better in `rbt post` (at least, it will be in the next release).
  • +Fixed