1548: updating a review request fails with "UnboundLocalError: local variable 'rsp' referenced before assignment"

irwan.*******@gmai***** (Google Code) (Is this you? Claim this profile.)
March 17, 2010
1510
version: RBTools-0.2rc1-py2.6.egg

What steps will reproduce the problem?
1. Using perforce (I don't know if it applies with other source control)
2. post-review <new-changelist>
3. post-review <the-same-changelist>

What is the expected output? What do you see instead?
expected: works. What I see: python interpreter error. Here's the debug
output (modified)
>>> p4 info
>>> repository info: Path: ['<our p4 server>', '<our p4 server>'], Base
path: None, Supports changesets: True
>>> Generating diff for changenum 3566762
>>> p4 describe -s 3566762
>>> Processing edit of <my-file>
>>> Writing "<my-modified-file>" to
"c:\users\irwand\appdata\local\temp\tmpyt3dgl"
>>> p4 print -o c:\users\irwand\appdata\local\temp\tmpyt3dgl -q
<my-modified-file>
>>> diff -urNp c:\users\irwand\appdata\local\temp\tmpyt3dgl <my-modified-file>
>>> Looking for 'mmulsow-linux.amer.corp.natinst.com /' cookie in
C:\Users\irwand\AppData\Roaming\.post-review-cookies.txt
>>> Loaded valid cookie -- no login required
>>> HTTP GETting /api/json/repositories/
>>> Repositories on Server: [{u'path': u'<our-p4-server>', u'tool':
u'Perforce', u'id': 1, u'name': u'<some-name>'}, {u'path':
u'<our-other-p4-server>', u'tool': u'Perforce', u'id': 2, u'name':
u'<some-name>'}]
>>> Server Aliases: ['<our-p4-server>', '<our-p4-server>']
>>> Attempting to create review request on <our-p4-server> for 3566762
>>> HTTP POSTing to
http://mmulsow-linux.amer.corp.natinst.com/api/json/reviewrequests/new/:
{'repository_path': u'<our-p4-server>', 'changenum': '3566762'}
>>> Got API Error 204 (HTTP code 200): The change number specified has
already been used
>>> Error data: {u'stat': u'fail', u'review_request': {u'status':
u'pending', u'last_updated': u'2010-03-17 09:54:06', u'description':
u'junk\n', u'repository': {u'path': u'<our-p4-server>', u'tool':
u'Perforce', u'id': 1, u'name': u'<some-name>'}, u'public': False,
u'target_groups': [], u'bugs_closed': u'',
u'changenum': 3566762, u'target_people': [], u'testing_done': u'',
u'branch': u'', u'submitter': {u'username': u'irwand', u'first_name':
u'Irwan', u'last_name': u'Djajadi', u'url': u'/users/irwand/', u'id': 9,
u'fullname': u'Irwan Djajadi', u'email': u'irwan.djajadi@ni.com'},
u'time_added': u'2010-03-17 09:54:06', u'summary': u'junk', u'id': 459},
u'err': {u'msg': u'The change number specified has already been used',
u'code': 204}}
>>> Review request already exists. Updating it...
Traceback (most recent call last):
  File "C:\Python26\Scripts\post-review-script.py", line 8, in <module>
    load_entry_point('RBTools==0.2rc1', 'console_scripts', 'post-review')()
  File
"C:\Python26\lib\site-packages\rbtools-0.2rc1-py2.6.egg\rbtools\postreview.py",
line 2774, in main
    submit_as=options.submit_as)
  File
"C:\Python26\lib\site-packages\rbtools-0.2rc1-py2.6.egg\rbtools\postreview.py",
line 2423, in tempt_fate
    review_request = server.new_review_request(changenum, submit_as)
  File
"C:\Python26\lib\site-packages\rbtools-0.2rc1-py2.6.egg\rbtools\postreview.py",
line 427, in new_review_request
    rsp['review_request']['id'])
UnboundLocalError: local variable 'rsp' referenced before assignment

What operating system are you using? What browser?
Windows 7. Browser isn't used to reproduce.

Please provide any additional information below.
This did not happen with rbtools beta2
#2 seagl*****@gmai***** (Google Code) (Is this you? Claim this profile.)
I also got this error when I post a review request from perforce changlist.
chipx86
#3 chipx86
Upgrade to the nightlies.