1540: Add basic sanity checks to git repo URL mask checking

emil****@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 4, 2014 
board.org/


What version are you running?

1.5b1

What's the URL of the page this enhancement relates to, if any?

Posting of a new patch.

Describe the enhancement and the motivation for it.

When adding a new git repository, you have to specify some URL mask to 
allow reviewboard to access the raw files (to generate diffs).  An improper 
URL mask can lead to exceptions.

As a first pass, RB should somehow check that (a gitweb) URL at least 
generates some sort of gitweb-like output if you pass in some bogus hashes, 
as opposed to a 404 or 500 or other server error, at the time the 
repository is created.  (I suppose this should merely be advisory, since 
the server in question might be offline at the time it is being added to 
RB.)

When there are errors, of course, the exceptions should be caught and 
brought to an administrator's attention.  (I don't know what the timeout 
behavior is, but that should probably be configurable too so that the RB UI 
remains usable if the remote gitweb/etc server is down.)
chipx86
#1 chipx86 
It is. This is a new feature and will get cleaned up a bit before release. The plan
is to have a simple drop-down with some fields, much like the Hosting Service
settings, so you can just select "gitweb" or whatever and fill in one or two things.
  • +Confirmed
  • +Milestone-Release1.5
chipx86
#2 chipx86 
Hoping to make this better in an early 1.5.x. For now, companies are waiting for a final release to upgrade, and while this UI and current validation isn't ideal, it doesn't really prevent people from using it.
  • -Milestone-Release1.5
    +Milestone-Release1.5.x
david
#3 david
  • +Component-Admin
chipx86
#4 chipx86 
Pushing these out, since they won't happen for 1.5.x. The focus is on getting 1.6 out right now.
  • +Milestone-Release1.6
chipx86
#5 chipx86
  • +Milestone-Release1.6.x
david
#6 david
  • -Milestone-Release1.6.x
david
#7 david 
I think the hosting services improve this a lot. If people are doing something very custom, there's not a lot of additional sanity checking that we can do.
  • -Confirmed
    +Fixed