chipx86

1534: Side-by-side diffs in HTML e-mails sometimes have cells screwed up

chipx86
chipx86
 chipx86
Aug. 7, 2013 
What version are you running?
1.5 beta 2


This was tested with GMail.

A recent e-mail containing a comment with a side-by-side diff had cells
positioned incorrectly. There was an extra column, which contained one of
the inserts.
broken-email.txt 
--===============1832555727==
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviews.reviewboard.org/r/1459/#review1851
-----------------------------------------------------------
Ship it!
we are already doing some curl'ing with the web api at work, so I'd love to=
 have this feature :)
djblets/webapi/auth.py
<http://reviews.reviewboard.org/r/1459/#comment2620>
    why not just do `encoded_auth.decode('base64')` ?  </nitpick>
djblets/webapi/errors.py
<http://reviews.reviewboard.org/r/1459/#comment2621>
    definitely a nitpick, but why not define the basic auth headers only on=
ce for DRYness' sake?
- Dan
On 2010-03-06 16:11:56, Christian Hammond wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://

 






  


 










 

  

   david

  

 
 

  

    
     

   
   #1
   david


  


  
I haven't seen this in some time.



  
    


   
  • 
    
    
    +Fixed
    
   
    •