1505: Cannot produce request from unified diff

fid***@gmai***** (Google Code) (Is this you? Claim this profile.)
Feb. 20, 2010 
What version are you running?
1.0.5.1

What's the URL of the page containing the problem?
/r/new/

What steps will reproduce the problem?
1. Choose to create new review request
2. Upload diff made from `diff -urw onedir anotherdir`

What is the expected output? What do you see instead?

I expected a new review request.
I get "The selected file does not appear to be a diff."


What operating system are you using? What browser?
Debian sid.  Firefox 3.6.


Please provide any additional information below.

I attach a diff here.  I have modified the directory names slightly, but it
should still be a valid unified diff.
diff_20100218092956.diff 
diff -urw /www/somesite/include/classes/Webshop.php /www/somesite-20100218092956/include/classes/Webshop.php
--- /www/somesite/include/classes/Webshop.php	2010-02-18 06:56:17.000000000 +0100
+++ /www/somesite-20100218092956/include/classes/Webshop.php	2010-02-18 09:33:37.000000000 +0100
@@ -58,7 +58,8 @@
           return $wsdomain->getWebshop();
         }
         else {
-          trigger_error( 'Webshop::getInstance with no $id and nothing got from SEVER_NAME',
+          trigger_error( 'Webshop::getInstance with no $id and nothing got from SEVER_NAME.'
+                         .'  Referrer: '. $_SERVER['HTTP_REFERER'],
                          E_USER_ERROR );
         }
       }
david
#1 david 
A raw diff like this, even when it's in the unified format, isn't going to work. Review 
Board requires diffs created with SCM revision information (depending on the SCM used) 
so that it can fetch the right versions to create the side-by-side view.
  • +UserError