1502: Plain-text review request e-mails should use the full name in the signature
- Fixed
- Review Board
| yab***@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| June 20, 2011 |
What version are you running? 1.0.5.1 What steps will reproduce the problem? 1. post review request using post-review.py with different submit-as and username params 2. open review reqest notification email 3. try to guess the submiter if there is more then one person with the same first name in your team What is the expected output? What do you see instead? Notification email sender is the one passed as "username", not the one specified as "submit-as" param. I would like to see user specified as "submit-as" in "From" email header, so I could quickly distinguish the submitter. Email signature is like: "Thanks, John" and should be like: "Thanks, John Doe" If there is more then one person with the same first name, You can't say who submitted a request. What operating system are you using? What browser? Linux & Firefox 3.5
There's really two things requested here. One is that we add the last name to the signature. The other is that we use the name from the Submit As, instead of the Username. (Correct me if I'm wrong here.) The former we can do, though honestly, from the From: and the "So and so wrote:" lines, I don't know that it's really that problematic and confusing. I'm tempted to punt this one. I don't see how the latter is a problem today. Maybe we've since fixed it? The code shows that we're using the submitter of the review request itself, which should always be right. We don't want to display any name other than the user who owns that review request.
-
- Priority-Medium - Milestone-Release1.5 + Priority-Low + Milestone-Release1.5.x -
+ Plain-text review request e-mails should use the full name in the signature
Your logic is based on the assumtion that "Submit As" is used to send review request email. In my version it's not. Last name in signature wouldn't be that important if sender would be correct. Right now it's the only way to identify review owner when using post-review.py with some generic user (see bug attachment). So it's problematic. From fields and "So and so wrote:" are useful only in replies. Please, first test if the bug still exists before closing it.
I never closed the bug.
