1499: post-review tool can't use some forms of CVS/Root entries

erez.bi*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Nov. 10, 2010
What version are you running?
RB - 1.0.5.1
post-review - 0.8

What's the URL of the page containing the problem?
NA

What steps will reproduce the problem?
1. Set CVSROOT to ":pserver:cumputer:/path" and check out the tree.
2. Try and run post-review, it'll fail with incorrect path to CVS repository

I fixed it with using this code change;
        i = repository_path.find("@")
        if i != -1:
            repository_path = repository_path[i + 1:]
        else:
            i = repository_path.find("pserver:")
            if i != -1:
                repository_path = repository_path[i+8:]
#1 erez.bi*******@gmai***** (Google Code) (Is this you? Claim this profile.)
Change was in CVSClient::get_repository_info
chipx86
#2 chipx86
Can you submit a patch to http://reviews.reviewboard.org/ ?
  • +NeedInfo
  • +Component-RBTools
david
#3 david
  • -NeedInfo
    +PendingReview
david
#4 david
  • -PendingReview
    +Fixed