1496: Unicode Char not support in diff viewer
- Incomplete
- Review Board
| infa****@gmai***** (Google Code) (Is this you? Claim this profile.) | |
| June 24, 2012 | |
| 1493, 1624 |
What version are you running? 1.1 alpha 3(dev) What's the URL of the page containing the problem? /r/326/diff/ What steps will reproduce the problem? 1.Load attached diff 2.Or create a diff with Unicode Characters. 3. Unicode works fine in the summary, description but not in the diff viewer What is the expected output? What do you see instead? Note that Unicode characters in the diff don't work. What operating system are you using? What browser? Linux/Firefox Please provide any additional information below. Index: unicode.c =================================================================== --- unicode.c (revision 0) +++ unicode.c (revision 0) @@ -0,0 +1,3 @@ +This file is to test unicode working in Reviewboard. + +このファイルはReviewboardではたらくunicodeをテストすることである。 Property changes on: unicode.c ___________________________________________________________________ Added: svn:eol-style + native
Hmm. Perhaps the database isn't set to unicode char types? Christian, can we get rb-site to fix the character set?
Hmm, actually that's part of the diff. Huh.
The diff is stored fine in the database. So the problem is somewhere in djblets/display. A note, that this is a regression as in 1.0.5.1 unicode diffs display correctly. (same diff same SVN).
Concerning merged issue 1493: Diff Viewer does not display Cyrillic symbols Is not a regression, because it did happen also in 1.0.5.1 And I was working with ANSI symbols, not with Unicode
Still occurring with ReviewBoard 1.5
-
+ Component-DiffViewer
Same applies to Latin alphabets with extra symbols, like http://en.wikipedia.org/wiki/Double_acute_accent. So I cannot refer to Pál Erdős (http://en.wikipedia.org/wiki/Paul_Erd%C5%91s) in my comments properly.
If anyone is still encountering this, we need to know: (a) repository type (b) specific configuration for accessing repository (for types that have multiple access methods like ssh/https/etc). (c) web server configuration
-
+ NeedInfo
-
- NeedInfo + Incomplete