147: Ability to view complete source files without diff coloring/block insertions
- Fixed
- Review Board
| br***@vmwar***** (Google Code) (Is this you? Claim this profile.) | |
| Jan. 22, 2014 | |
| 852, 936, 973, 1209, 1316, 2136 |
What's the URL of the page containing the problem? http://reviewboard.eng.vmware.com/r/675/diff/ What steps will reproduce the problem? 1. Any diff 2. 3. What is the expected output? What do you see instead? Feature: A button, or something, that shows just the old text or the new text aside fromm the diff. What operating system are you using? What browser? XPsp2, firefox 2.0.4 Please provide any additional information below.
-
- Type-Defect + Type-Enhancement
I'm not sure what you mean by "the old text or the new text aside fromm the diff". Can you clarify?
-
+ NeedInfo
Specifically, I'd like to be able see one side or the other instead of the side-by-side view. I guess I want to see the code without the diff overlay. For instance, when there are tons of diffs, the code flow confuses me and it would help to be able to see the code without the diffs overlayed. Just something to consider.
-
- NeedInfo + New -
+ Ability to view complete source files without diff coloring/block insertions
-
+ Component-DiffViewer
-
+ Milestone-Extensions + ExtensionIdea
I see Issue 973 has been merged into this issue. However, my initial request was mainly to be able to review existing code. Not especially comparing with any other version. Just do a code review on existing source code (then no diff). This was just to clarify. Regards
Are there any plans to proceed with this feature? I know many users who would find it extremely useful. The side-by-side diff view can become cluttered very quickly in larger reviews. It would be useful to be able to collapse the column of the table containing either the old output or new output. Hopefully this could be done client-side with some suitable javascript and css.
I would definitely agree that this would be a great feature. I agree with #11 that I'm more interested in reviews of non-modified files.
There are no plans for this. You could accomplish it with a Greasemonkey or Stylish script though by changing the CSS. It's very unlikely we'll bake it into Review Board. Maybe someone can code it up in 2.0 when extensions are there.
Is this something you won't implement because you feel you have more important things to do and precious little time, or is it something you object to on a design level? I.e., if someone sent a fix for this, would you include it?
I think it really depends on how it was done. We don't want to add this if it makes things significantly more complicated.
Hi. I've reviewed quickly all the different issues merged into this one and I think there are 2 slightly different functionality requests: 1) Being able to review new code only: not yet in a repository, review plain files, not diff file 2) Being able to download separately each side of the current diff view. I mean, for each file, to be able to download the versions before and after the diff is applied. I am very interested in 2). This can be useful when the file is not easy to review in text format and can be displayed nicely in an external application. I understand that this can easily be reproduced manually by checking out the repository and applying the diff file to get each version of the file but I think it's the point of RB to make this straightforward. I do not know the internals of RB but it seems to me that at some point it must checkout/generate both files in order to generate the diff view... Should this be tracked in a separate Issue?
The original and patched files are available through the API. You could write a script or extension to let you download it from that.
Actually, these are now also available in the UI in the master branch (there are little download links). Between that and the text-file review (attaching files to review requests instead of uploading diffs), I think this is probably covered well enough.
-
- New + Fixed