1450: Attempt to mark closed review submitted again yields "Internal error: 200 OK"

petrva*******@gmai***** (Google Code) (Is this you? Claim this profile.)
chipx86
 chipx86
May 21, 2010 
What version are you running?
1.0.5.1 @ VMware

What's the URL of the page containing the problem?

/r/12345/ on VMware's internal reviewboard.

What steps will reproduce the problem?
1. Open browser on system A.  Go to review ABCD.
2. Open browser on system B.  Go to review ABCD.
3. Mark review submitted on system B.
4. Pretend you do not remember what you did, and try to mark review
submitted on system A (without reloading page).

What is the expected output? What do you see instead?

After some thinking this error is generated:
===
Error:
Setting the review request as submitted has failed due to a server error:
200 OK

Please try again later. If this continues to happen, please report it to
your administrator.
===
I would expect some nice output saying that review was already submitted,
or that someone else modified review since last reload, or anything else
than "Error: OK"...

What operating system are you using? What browser?

Linux, SeaMonkey 1.1.15.

Please provide any additional information below.
chipx86
#1 chipx86
  • +Confirmed
  • +Milestone-Release1.5
    +Component-Reviews
mconley
#2 mconley 
I tried reproducing this error, but no luck.  Mind you, I was using two separate
sessions on the same machine, but I don't think that should matter much.

Used Ubuntu with Seamonkey, Firefox, and Epiphany browsers.
chipx86
#3 chipx86 
This was likely fixed by another change. I can't reproduce it with anything modern
and the code (which has since been rewritten) doesn't appear to be able to trigger
this error anymore.
  • -Confirmed
    +Fixed
  • +chipx86